Fix variables not allowed in ucp#10304
Merged
fdncred merged 5 commits intonushell:mainfrom Sep 10, 2023
Merged
Conversation
Contributor
|
Thanks @dmatos2012. Let's try this out! |
Contributor
|
@amtoine I think this fixes the problem you were seeing in your script. Can you try it out and let me know how it goes? I can't find our discord chat where you reported this problem. |
Member
|
i'm building my terminal and then Nushell, will come back shortly ♻️ |
Member
|
@fdncred @dmatos2012 |
Contributor
|
yay! good work David! |
Contributor
Author
|
Yay thanks 🙏! Let's keep those bug reports coming 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10300 , where using variables didnt work with
ucpas it was only expecting aExpr::FilePath.Before: (from the issue)
Now:
Also added the test to ensure its working:) . Oh, and I tweaked again slightly the messages on two tests because now the whole
pathis printed rather thana. Say:User-Facing Changes
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_usedto check that you're using the standard code stylecargo test --workspaceto check that all tests pass (on Windows make sure to enable developer mode)cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"to run the tests for the standard libraryAfter Submitting