Skip to content

from url doesn't seem to work well with absolute URLs #6854

@webbedspace

Description

@webbedspace

Describe the bug

I notice that from url doesn't seem to be very useful at the moment - not only does it only seem to handle search params, but it also can't tell the difference between the first search param's name and the start of the URL.

How to reproduce

〉'https://www.smwcentral.net/?p=section&s=smwmusic&f[name]=vldc&f[author]=&f[tags]=&f[featured]=&f[description]=' | from url
╭───────────────────────────────┬──────────╮
│ https://www.smwcentral.net/?p │ section  │
│ s                             │ smwmusic │
│ f[name]                       │ vldc     │
│ f[author]                     │          │
│ f[tags]                       │          │
│ f[featured]                   │          │
│ f[description]                │          │
╰───────────────────────────────┴──────────╯

Expected behavior

Let's compare this to an interface that's already in production:

image

It would be nice if the other parts that the DOM's URL() recognises (host, href, pathname, etc.) were added to the final record, and searchterms moved to an inner record. However, the fact that this currently can't even properly distinguish the first search term's name feels like a bug to me.

Screenshots

No response

Configuration

key value
version 0.70.0
branch
commit_hash 9ef65dc
build_os windows-x86_64
build_target x86_64-pc-windows-msvc
rust_version rustc 1.64.0 (a55dd71d5 2022-09-19)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.64.0 (387270bc7 2022-09-16)
pkg_version 0.70.0
build_time 2022-10-18 18:55:02 +00:00
build_rust_channel release
features database, dataframe, default, trash, which, zip
installed_plugins

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions