Skip to content

Commit f2b977b

Browse files
sophiajtsophiajt
authored
improve operation mismatch errors (#8800)
# Description This improves the operation mismatch error in a few ways: * We now detect if the left-hand side of the operation is at fault, and show a simpler error/error message if it is * Removed the unhelpful hint * Updated the error text to make it clear what types are causing the issue ![image](https://user-images.githubusercontent.com/547158/230666329-537a8cae-6350-4ee7-878e-777e05c4f265.png) ![image](https://user-images.githubusercontent.com/547158/230666353-93529dc2-039a-4774-a84c-a6faac94d8e2.png) # User-Facing Changes Error texts and spans will change # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
1 parent 35e8420 commit f2b977b

7 files changed

Lines changed: 316 additions & 61 deletions

File tree

‎benches/benchmarks.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ fn parser_benchmarks(c: &mut Criterion) {
2222
c.bench_function("parse_default_env_file", |b| {
2323
b.iter_batched(
2424
|| nu_protocol::engine::StateWorkingSet::new(&engine_state),
25-
|mut working_set| parse(&mut working_set, None, default_env, false, &[]),
25+
|mut working_set| parse(&mut working_set, None, default_env, false),
2626
BatchSize::SmallInput,
2727
)
2828
});
@@ -31,7 +31,7 @@ fn parser_benchmarks(c: &mut Criterion) {
3131
c.bench_function("parse_default_config_file", |b| {
3232
b.iter_batched(
3333
|| nu_protocol::engine::StateWorkingSet::new(&engine_state),
34-
|mut working_set| parse(&mut working_set, None, default_config, false, &[]),
34+
|mut working_set| parse(&mut working_set, None, default_config, false),
3535
BatchSize::SmallInput,
3636
)
3737
});

0 commit comments

Comments
 (0)