remove the deprecated index argument from filter commands' closure signature (#14594)

Bahex · web-flow · commit 3760910f0bbf · 2024-12-15T15:27:13.000-06:00
# Description

A lot of filter commands that have a closure argument (`each`, `filter`,
etc), have a wrong signature for the closure, indicating an extra int
argument for the closure.

I think they are a left over from before `enumerate` was added, used to
access iteration index. None of the commands changed in this PR actually
supply this int argument.

# User-Facing Changes
N/A

# Tests + Formatting
- 🟢 toolkit fmt
- 🟢 toolkit clippy
- 🟢 toolkit test
- 🟢 toolkit test stdlib

# After Submitting
N/A
diff --git a/crates/nu-cmd-extra/src/extra/filters/each_while.rs b/crates/nu-cmd-extra/src/extra/filters/each_while.rs
@@ -25,7 +25,7 @@ impl Command for EachWhile {
             )])
             .required(
                 "closure",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "the closure to run",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/all.rs b/crates/nu-command/src/filters/all.rs
@@ -14,7 +14,7 @@ impl Command for All {
             .input_output_types(vec![(Type::List(Box::new(Type::Any)), Type::Bool)])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "A closure that must evaluate to a boolean.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/any.rs b/crates/nu-command/src/filters/any.rs
@@ -14,7 +14,7 @@ impl Command for Any {
             .input_output_types(vec![(Type::List(Box::new(Type::Any)), Type::Bool)])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "A closure that must evaluate to a boolean.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/filter.rs b/crates/nu-command/src/filters/filter.rs
@@ -30,7 +30,7 @@ a variable. On the other hand, the "row condition" syntax is not supported."#
             ])
             .required(
                 "closure",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "Predicate closure.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/par_each.rs b/crates/nu-command/src/filters/par_each.rs
@@ -38,7 +38,7 @@ impl Command for ParEach {
             )
             .required(
                 "closure",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "The closure to run.",
             )
             .allow_variants_without_examples(true)
diff --git a/crates/nu-command/src/filters/reduce.rs b/crates/nu-command/src/filters/reduce.rs
@@ -24,11 +24,7 @@ impl Command for Reduce {
             )
             .required(
                 "closure",
-                SyntaxShape::Closure(Some(vec![
-                    SyntaxShape::Any,
-                    SyntaxShape::Any,
-                    SyntaxShape::Int,
-                ])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Any])),
                 "Reducing function.",
             )
             .allow_variants_without_examples(true)
diff --git a/crates/nu-command/src/filters/skip/skip_until.rs b/crates/nu-command/src/filters/skip/skip_until.rs
@@ -20,7 +20,7 @@ impl Command for SkipUntil {
             ])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "The predicate that skipped element must not match.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/skip/skip_while.rs b/crates/nu-command/src/filters/skip/skip_while.rs
@@ -20,7 +20,7 @@ impl Command for SkipWhile {
             ])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "The predicate that skipped element must match.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/take/take_until.rs b/crates/nu-command/src/filters/take/take_until.rs
@@ -17,7 +17,7 @@ impl Command for TakeUntil {
             )])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "The predicate that element(s) must not match.",
             )
             .category(Category::Filters)
diff --git a/crates/nu-command/src/filters/take/take_while.rs b/crates/nu-command/src/filters/take/take_while.rs
@@ -20,7 +20,7 @@ impl Command for TakeWhile {
             ])
             .required(
                 "predicate",
-                SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),
+                SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),
                 "The predicate that element(s) must match.",
             )
             .category(Category::Filters)

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ impl Command for EachWhile {`
`25`	`25`	`)])`
`26`	`26`	`.required(`
`27`	`27`	`"closure",`
`28`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`28`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`29`	`29`	`"the closure to run",`
`30`	`30`	`)`
`31`	`31`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ impl Command for All {`
`14`	`14`	`.input_output_types(vec![(Type::List(Box::new(Type::Any)), Type::Bool)])`
`15`	`15`	`.required(`
`16`	`16`	`"predicate",`
`17`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`17`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`18`	`18`	`"A closure that must evaluate to a boolean.",`
`19`	`19`	`)`
`20`	`20`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ impl Command for Any {`
`14`	`14`	`.input_output_types(vec![(Type::List(Box::new(Type::Any)), Type::Bool)])`
`15`	`15`	`.required(`
`16`	`16`	`"predicate",`
`17`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`17`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`18`	`18`	`"A closure that must evaluate to a boolean.",`
`19`	`19`	`)`
`20`	`20`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ a variable. On the other hand, the "row condition" syntax is not supported."#`
`30`	`30`	`])`
`31`	`31`	`.required(`
`32`	`32`	`"closure",`
`33`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`33`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`34`	`34`	`"Predicate closure.",`
`35`	`35`	`)`
`36`	`36`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ impl Command for ParEach {`
`38`	`38`	`)`
`39`	`39`	`.required(`
`40`	`40`	`"closure",`
`41`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`41`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`42`	`42`	`"The closure to run.",`
`43`	`43`	`)`
`44`	`44`	`.allow_variants_without_examples(true)`
Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,7 @@ impl Command for Reduce {`
`24`	`24`	`)`
`25`	`25`	`.required(`
`26`	`26`	`"closure",`
`27`		`- SyntaxShape::Closure(Some(vec![`
`28`		`- SyntaxShape::Any,`
`29`		`- SyntaxShape::Any,`
`30`		`- SyntaxShape::Int,`
`31`		`- ])),`
	`27`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Any])),`
`32`	`28`	`"Reducing function.",`
`33`	`29`	`)`
`34`	`30`	`.allow_variants_without_examples(true)`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ impl Command for SkipUntil {`
`20`	`20`	`])`
`21`	`21`	`.required(`
`22`	`22`	`"predicate",`
`23`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`23`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`24`	`24`	`"The predicate that skipped element must not match.",`
`25`	`25`	`)`
`26`	`26`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ impl Command for TakeUntil {`
`17`	`17`	`)])`
`18`	`18`	`.required(`
`19`	`19`	`"predicate",`
`20`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`20`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`21`	`21`	`"The predicate that element(s) must not match.",`
`22`	`22`	`)`
`23`	`23`	`.category(Category::Filters)`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ impl Command for TakeWhile {`
`20`	`20`	`])`
`21`	`21`	`.required(`
`22`	`22`	`"predicate",`
`23`		`- SyntaxShape::Closure(Some(vec![SyntaxShape::Any, SyntaxShape::Int])),`
	`23`	`+ SyntaxShape::Closure(Some(vec![SyntaxShape::Any])),`
`24`	`24`	`"The predicate that element(s) must match.",`
`25`	`25`	`)`
`26`	`26`	`.category(Category::Filters)`