Skip to content

remove deprecated --switch: bool#55

Merged
amtoine merged 2 commits intonushell:mainfrom
amtoine:fix-deprecated-bool-annotation
Dec 23, 2023
Merged

remove deprecated --switch: bool#55
amtoine merged 2 commits intonushell:mainfrom
amtoine:fix-deprecated-bool-annotation

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Dec 23, 2023

related to

description

this PR will suppress the deprecation warning from nushell/nushell#11365 which is deprecating : bool annotations for switches.

this didn't break anything but did show a bunch of spurious deprecation warnings in CI for instance: https://github.com/amtoine/nu-git-manager/actions/runs/7307569422/job/19913395508#step:6:17

@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Dec 23, 2023

this is a pretty simple change, i'll land it to fix dependants of Nupm 😌

@amtoine amtoine merged commit e46e2a9 into nushell:main Dec 23, 2023
@amtoine amtoine deleted the fix-deprecated-bool-annotation branch December 23, 2023 10:09
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Dec 23, 2023

note that now, the CI does not have warnings anymore 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant