Skip to content

fix removed commands#645

Merged
sholderbach merged 3 commits intonushell:mainfrom
amtoine:fix-removed-commands
Oct 19, 2023
Merged

fix removed commands#645
sholderbach merged 3 commits intonushell:mainfrom
amtoine:fix-removed-commands

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Oct 19, 2023

related to

Important
breaking changes:

  • renaming random-list integer to random-list int in modules/random-list/random-list.nu

this PR removes mentions to removed commands from nushell/nushell#10567, nushell/nushell#10668 and nushell/nushell#10568.

the main change has been introduced with

sd 'random integer' 'random int' **/*.nu

running rg "$nothing|random integer|to xml .* --pretty" gives

  • before
modules/random-list/random-list.nu
85:# Generate a random integer list.
95:        random integer $range

modules/fun/wordle.nu
11:  let word = ($words | get (random integer 0..($words | length)) | get column1)

benchmarks/random-bytes.nu
5:        | each { random integer }

sourced/misc/password_generator/ReadMe.md
84:Obviously you can just use the `random chars` or `random integers` commands but I like to have words I can read in my passwords, and I think those generated by this script have sufficient entropy.

sourced/misc/password_generator/nupass.nu
43:  let random_numbers = (1..$words | par-each { |i| (random integer 0..99) } --threads $threads)
71:    return (0..($words - 1) | each { |it| (random integer 0..99 | into string) + ($random_words | get $it) } | reduce { |it
, acc| $acc + $it })
92:    | get (random integer 1..($numlines))
99:        let rint = (random integer 1..4)
119:    | get (random integer 0..($symbolcharslen - 1))
  • after
modules/random-list/random-list.nu
85:# Generate a random integer list.

sourced/misc/password_generator/ReadMe.md
84:Obviously you can just use the `random chars` or `random integers` commands but I like to have words I can read in my passwords, and I think those generated by this script have sufficient entropy.

Copy link
Copy Markdown
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sholderbach sholderbach merged commit ed9165f into nushell:main Oct 19, 2023
@amtoine amtoine deleted the fix-removed-commands branch October 19, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants