Skip to content

add a few enhancements to the create-pr script for releases#642

Merged
amtoine merged 3 commits intonushell:mainfrom
amtoine:enhance-create-pr-script
Nov 11, 2023
Merged

add a few enhancements to the create-pr script for releases#642
amtoine merged 3 commits intonushell:mainfrom
amtoine:enhance-create-pr-script

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Oct 18, 2023

related to

i had to use create-pr to open nushell/nushell.github.io#1114 and i thought the script could be improved in a few ways

  • the template had a hardcoded .0 path version in the semver, this PR removes is so that the CLI argument can be a full semver, e.g. 0.87.0
  • switch from explore to $env.EDITOR to preview the completed template: because it's valid markdown, it looks better in an editor
  • fetch the website repo with HTTP and push with SSH: this allows to not enter the password of an SSH key in the clone step

@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Nov 11, 2023

let's land this and see how it goes for next release note PR creation 😉

@amtoine amtoine merged commit d233262 into nushell:main Nov 11, 2023
@amtoine amtoine deleted the enhance-create-pr-script branch November 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant