make_release: do not annotate boolean switches in public API#635
Merged
amtoine merged 1 commit intonushell:mainfrom Oct 14, 2023
Merged
make_release: do not annotate boolean switches in public API#635amtoine merged 1 commit intonushell:mainfrom
amtoine merged 1 commit intonushell:mainfrom
Conversation
Member
Author
|
because i'm starting writing the release note of nushell/nushell.github.io#1071, i'll go ahead and land this simple and battle-tested change 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to
--xand--x: boolnushell#104560.86nushell.github.io#1071description
after the changes on boolean switches from nushell/nushell#10456, we need to not annotate then with
: boolwhen part of a public API.this PR is required for nushell/nushell.github.io#1071 to move forward.