Skip to content

tix the release note PR opening script#611

Merged
amtoine merged 2 commits intonushell:mainfrom
amtoine:fix-release-note-pr-script
Sep 20, 2023
Merged

tix the release note PR opening script#611
amtoine merged 2 commits intonushell:mainfrom
amtoine:fix-release-note-pr-script

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Sep 20, 2023

to open nushell/nushell.github.io#1071, i had to fix a few issues in the create_pr script of make_release/ 👀

  • str replace --string has been removed in 0.85 yesterday
  • a return in the middle of the script won't help opening the PR automatically 😆

lol otherwise of course it won't work xD
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Sep 20, 2023

as i've just run the script with these fixes, which created nushell/nushell.github.io#1071 successfully, i'll go ahead and land this PR 😌

@amtoine amtoine merged commit e64355b into nushell:main Sep 20, 2023
@amtoine amtoine deleted the fix-release-note-pr-script branch September 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant