fix readonly final class architecture side effect issue PHP8.2#645
Merged
cmgmyr merged 7 commits intonunomaduro:masterfrom Sep 28, 2023
Merged
fix readonly final class architecture side effect issue PHP8.2#645cmgmyr merged 7 commits intonunomaduro:masterfrom
cmgmyr merged 7 commits intonunomaduro:masterfrom
Conversation
Contributor
Author
|
@cmgmyr, @JustSteveKing or @nunomaduro, would it be possible to have an update on this PR ? Thank you so much |
Contributor
|
Thanks! I'm going to leave this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this fix the
[Architecture] Normal classes are forbidden. Classes must be final or abstracterror message.To fix the
[Style] Side effectsthis PR to PHP_CodeSniffer SideEffectsSniff is currently being made and reviewed following this issueI'm not quite sur about how to create tests for this new behavior as I haven't seen any test for the currently working behavior.
But I'd be happy to be wrong about this statement and to be showed which test I should update !