Merged
Conversation
Contributor
Author
|
PS: I assumed the latest dev branch, but not sure, can't find that info - checked https://github.com/nunit/nunit/blob/master/CONTRIBUTING.md |
jnm2
reviewed
Apr 7, 2021
Member
|
It is fine to merge this to the 3.13 dev branch, but our default dev branch is actually master. We are working on the 4.0 release, but merging bug fixes and changes like this back to this 3.13 branch for any point releases. We haven't fully setup this branch properly for PR builds yet so I will need to Admin merge it and then we can cherry pick to master. |
mikkelbu
approved these changes
Apr 12, 2021
Contributor
Author
|
FYI| looks great!
|
This was referenced Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current result:
Desired result:
Deterministic Build, see https://github.com/clairernovotny/DeterministicBuilds
Preview NuGet packages: https://ci.appveyor.com/project/304NotModified/nunit/builds/38580291/artifacts
And green check :)