build(pyproject.toml): drop support for python 3.9 (require 3.10+)#641
Merged
larsoner merged 7 commits intonumpy:mainfrom Sep 10, 2025
Merged
build(pyproject.toml): drop support for python 3.9 (require 3.10+)#641larsoner merged 7 commits intonumpy:mainfrom
larsoner merged 7 commits intonumpy:mainfrom
Conversation
Collaborator
|
@mattgebert now that we require 3.10 the style checkers want you to use |
…s per ruff UP038
…or the docscrape test
ruff UP007, UP045
Contributor
Author
|
@larsoner hey mate just bumping this to keep making progress. Been a month since I've finished the relevant commits. |
larsoner
approved these changes
Sep 10, 2025
Collaborator
|
Thanks for the ping @mattgebert . I don't get notified about commits so had no idea you'd made the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
In upgrading via #592 and #622, the new functionality for checking constructor docstrings fulfilled by the class docstring requires stable use of
__qualname__for the Validator class.The problem:
This property is not supported in dataclasses in python3.9, but from 3.10 onward (solves #637).
Suggestion:
Drop support for Python3.9, which EOL is Oct 2025, so #622 can be validated and merged.