Use ruff for linting and formatting#555
Merged
jarrodmillman merged 5 commits intonumpy:mainfrom May 11, 2024
Merged
Conversation
stefanv
reviewed
May 11, 2024
|
|
||
| Expect SA01 and EX01 errors if validation enabled. | ||
| """ | ||
| pass |
Contributor
There was a problem hiding this comment.
I did not know a function with only a docstring is valid!
stefanv
approved these changes
May 11, 2024
Contributor
stefanv
left a comment
There was a problem hiding this comment.
Looks good to me; I agree that it's better to get the toolchain in place quickly, and to the iteratively refine.
This was referenced May 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of issues:
BadExamplesinnumpydoc/tests/test_validate.py.pytest -v --pyargs numpydoc. For the prerelease test we runpytest -v --pyargs ..numpydoc/tests/hooksis in the source directory:but isn't in the installed package
I ignore a large number of linting checks because they don't have automated fixes (or their automated fixes are unsafe). I think we should eventually enable them one by one and implement the fixes in follow-up PRs. I would like to keep them separate because they will require more attention and careful review than these changes. I would like to get this PR in relatively quickly because I think moving to ruff is worth it. It is much faster, implements multiple tools, is being rapidly developed, and has been adding features specific for our community.