Filter DeprecationWarning in failing test for python 3.12 #523
Merged
larsoner merged 3 commits intonumpy:mainfrom Jan 9, 2024
Merged
Filter DeprecationWarning in failing test for python 3.12 #523larsoner merged 3 commits intonumpy:mainfrom
DeprecationWarning in failing test for python 3.12 #523larsoner merged 3 commits intonumpy:mainfrom
Conversation
Collaborator
larsoner
reviewed
Jan 9, 2024
larsoner
reviewed
Jan 9, 2024
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Contributor
Author
|
Thanks @larsoner , indeed I wasn't sure about the project policies about python versions. |
Collaborator
|
I think we can properly fix this rather than by filtering the |
Contributor
Author
|
I'm afraid I probably need a deeper look at the code to understand what you are proposing... I was hoping to be helpful , but if you can offer a better fix you are likely to be more efficient than me ... :) |
larsoner
approved these changes
Jan 9, 2024
Collaborator
|
Thanks @cmarmo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
it seems to me that the failing test in #522 and #512 is generated by a
DeprecationWarningnew in python 3.12.This pull request fixes the test filtering
DeprecationWarnings in that specific test.Closes #512.
Closes #522.
Thank you for considering it.