fix: encoding issue in numpydoc-validation#506
Closed
clatapie wants to merge 2 commits intonumpy:mainfrom
Closed
Conversation
Member
|
Thanks for your contribution. I see that #510 supercedes this PR now. |
Contributor
Agreed - I went ahead and merged #510 as the test there was really helpful in understanding what was going on and how the fix addresses the likely cases. Sorry we didn't get to this one @clatapie , but thanks for reporting the issue and the proposed fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505.