Fix clean_backref for extensions that have backrefs to inline elements.#499
Merged
rossbar merged 3 commits intonumpy:mainfrom Aug 26, 2023
Merged
Conversation
larsoner
reviewed
Aug 25, 2023
Collaborator
larsoner
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Ideally it would be nice if we could add a test that fails on main and passes on this PR -- @mcmtroffaes how difficult do you think this would be?
Contributor
Author
|
Thanks for the quick response. Yes, I think I should be able to add a test. |
Contributor
Author
|
I've added a test. |
rossbar
approved these changes
Aug 26, 2023
Contributor
rossbar
left a comment
There was a problem hiding this comment.
LGTM, thanks @mcmtroffaes !
Contributor
Author
|
Awesome, many thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported here:
mcmtroffaes/sphinxcontrib-bibtex#277