BUG: Don't leak internal exceptions when given an empty array#8614
Merged
mhvk merged 1 commit intonumpy:masterfrom Feb 18, 2017
Merged
BUG: Don't leak internal exceptions when given an empty array#8614mhvk merged 1 commit intonumpy:masterfrom
mhvk merged 1 commit intonumpy:masterfrom
Conversation
Contributor
|
Looks good (I would not have thought of the possibility of a function dealing with empty axis myself!) |
Member
Author
|
Good to merge? |
Contributor
|
Yes, looks all OK, so merging. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6927 (and its dupe, #7454)
This was made worse in #8441, which changed the exception from
IndexError, which is likely to not be swallowed by user code, to aStopIteration, which would cause silent failure if used inside a generator