BUG: Fix loss of dimensionality of np.ma.masked in ufunc#8508
Merged
ahaldane merged 1 commit intonumpy:masterfrom Jan 31, 2017
Merged
BUG: Fix loss of dimensionality of np.ma.masked in ufunc#8508ahaldane merged 1 commit intonumpy:masterfrom
ahaldane merged 1 commit intonumpy:masterfrom
Conversation
2e02815 to
c1e66e4
Compare
eric-wieser
commented
Jan 20, 2017
| def __array_finalize__(self, obj): | ||
| return | ||
|
|
||
| def __array_wrap__(self, obj): |
Member
Author
There was a problem hiding this comment.
I'm surprised this didn't error already when something tried to pass it a context
Member
|
Looks absolutely correct to me, and it's surprising the old behavior didn't cause problems before. Code and commits look nice and clean, I'll merge in a little bit. |
Member
|
Merging, thanks @eric-wieser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8505. Previously, the result of invoking ufuncs on a
MaskedConstantwould always be np.ma.masked, which wasn't always of the correct shape