Skip to content

BUG: Extend glibc complex trig functions blacklist to glibc < 2.18.#7518

Merged
charris merged 1 commit intonumpy:masterfrom
nforro:issue-7517
Apr 7, 2016
Merged

BUG: Extend glibc complex trig functions blacklist to glibc < 2.18.#7518
charris merged 1 commit intonumpy:masterfrom
nforro:issue-7517

Conversation

@nforro
Copy link
Copy Markdown
Contributor

@nforro nforro commented Apr 6, 2016

The library complex trig functions are inaccurate also in glibc
versions 2.16 and 2.17, so extend the blacklist.

Closes #7517.

The library complex trig functions are inaccurate also in glibc
versions 2.16 and 2.17, so extend the blacklist.

Closes numpy#7517.
@charris
Copy link
Copy Markdown
Member

charris commented Apr 6, 2016

The problems seem specific to carcsinh, so if possible could you make the blacklist specific to that?

@nforro
Copy link
Copy Markdown
Contributor Author

nforro commented Apr 7, 2016

Yes, these problems are specific to carcsinh, but if I blacklist just that, the tests begin to fail on carcsin and then the same repeats with carctanh and carctan. There is no carccosh nor carccos in test_loss_of_precision, so I'm not sure about those. But there are two cacos[h] related bugs that were resolved in glibc 2.18: 15023 and 15327, so I thought it might be better to blacklist those as well.

@charris charris merged commit 3920a29 into numpy:master Apr 7, 2016
@charris
Copy link
Copy Markdown
Member

charris commented Apr 7, 2016

OK, merged. Thanks @nforro .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants