MAIN: fix to #7382, make scl in np.average writeable#7505
Merged
charris merged 1 commit intonumpy:masterfrom Apr 5, 2016
Merged
MAIN: fix to #7382, make scl in np.average writeable#7505charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
Member
|
Note that you could make the returned array writable by setting the flag, which might be an alternative to copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7382 we make
np.averageusebroadcast_towhen returningscl, but as pointed out in #5706,broadcast_toreturns a read-only array, which might cause problems. This PR fixes that by adding a.copy(), and also avoiding the broadcast/copy if not needed.