BUG, MAINT: Improve fromnumeric.py interface for downstream compatibility #7325
Merged
njsmith merged 2 commits intonumpy:masterfrom Mar 22, 2016
gfyoung:wrapit_keyword
Merged
BUG, MAINT: Improve fromnumeric.py interface for downstream compatibility #7325njsmith merged 2 commits intonumpy:masterfrom gfyoung:wrapit_keyword
njsmith merged 2 commits intonumpy:masterfrom
gfyoung:wrapit_keyword
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation stemmed from PR in
pandasin which I was trying to makesearchsortedinpandashave a compatible signature withnumpywithout externalizing thesorterargument (it isn't used in thepandasimplementation) by accepting akwargsargument to swallow thesorterarg.However, because
np.searchsortedtreatssorterlike a positional argument in the internal call and NOT as a keyword argument as it should be based on the method signature, it was not possible to do so. This PR fixes that inconsistency as well as in all othernpfunctions that use_wrapitin the implementation.xref #12644 (
pandas)