TYP: fix sliding_window_view axis parameter typing#31240
Merged
Conversation
The axis parameter now accepts int | tuple[int, ...] instead of just SupportsIndex, matching the documentation and implementation. Fixes numpy#31233
Member
|
Thanks; looks good. Next time, try not to ignore the PR template which includes the AI disclosure :) |
jorenham
approved these changes
Apr 14, 2026
|
Thanks for the help as I don't know how to use github yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
The axis parameter in
sliding_window_viewnow acceptsint | tuple[int, ...]instead of justSupportsIndex, matching the documentation and implementation.This fixes the type inconsistency issue reported in #31233.
Changes:
axis: SupportsIndex | Nonetoaxis: int | tuple[int, ...] | Nonein both overloads innumpy/lib/_stride_tricks_impl.pyiThank you for your work on this project. I hope this small fix is helpful. Please let me know if there is anything to adjust.
Warmly, RoomWithOutRoof