MAINT: f2py: replace deprecated sprintf with snprintf#30998
Merged
Conversation
lucascolley
commented
Mar 12, 2026
lucascolley
commented
Mar 12, 2026
mattip
reviewed
Mar 12, 2026
DWesl
reviewed
Mar 13, 2026
Comment on lines
+855
to
857
| size_t len = strlen(mess); | ||
| snprintf(mess + len, F2PY_MESSAGE_BUFFER_SIZE - len, | ||
| " -- expected str|bytes|sequence-of-str-or-bytes, got "); |
Contributor
There was a problem hiding this comment.
For this particular case, would strcat/strncat work? I suspect strcat will have the same problems as sprintf, but strncat should work.
Suggested change
| size_t len = strlen(mess); | |
| snprintf(mess + len, F2PY_MESSAGE_BUFFER_SIZE - len, | |
| " -- expected str|bytes|sequence-of-str-or-bytes, got "); | |
| size_t len = strlen(mess); | |
| strncat(mess, " -- expected str|bytes|sequence-of-str-or-bytes, got ", | |
| F2PY_MESSAGE_BUFFER_SIZE - len); |
(This will need #include <string.h> somewhere in the resulting file)
Contributor
Author
|
can we merge it? Happy to apply the suggestion from @DWesl if others agree |
Member
|
Thanks @lucascolley |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
See gh-30997
AI Disclosure
I wasn't sure what the size should be for the
mess + strlen(mess)case so ChatGPT suggested that patch.cc @mattip