Skip to content

BUG: fix meshgrid return type#30707

Merged
jorenham merged 6 commits intonumpy:mainfrom
antareepsarkar:main_2
Jan 24, 2026
Merged

BUG: fix meshgrid return type#30707
jorenham merged 6 commits intonumpy:mainfrom
antareepsarkar:main_2

Conversation

@antareepsarkar
Copy link
Copy Markdown
Contributor

resolves #30641

This PR is to make sure that np.meshgrid always returns a tuple regardless of the values of copy and sparse.

@jorenham
Copy link
Copy Markdown
Member

please undo the submodule updates

@jorenham jorenham changed the title FIX: fix meshgrid return type BUG: fix meshgrid return type Jan 22, 2026
@jorenham
Copy link
Copy Markdown
Member

How to do that? I do not know that.

I'm sure that your favorite LLM knows ;)

@jorenham
Copy link
Copy Markdown
Member

Could you add a release note?

@jorenham jorenham added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jan 22, 2026
@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Why errors? I guess that tests are successful.

@antareepsarkar
Copy link
Copy Markdown
Contributor Author

What should be the name of the file of the release note?
In this PR? Or, a separate PR for that?

@jorenham
Copy link
Copy Markdown
Member

@antareepsarkar
Copy link
Copy Markdown
Contributor Author

See https://github.com/numpy/numpy/tree/main/doc/release/upcoming_changes#changelog

Will it be improvement or change?

@jorenham
Copy link
Copy Markdown
Member

change

change

Update documentation to reflect that `meshgrid` now consistently returns a tuple.
@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Why are the tests failing?

@jorenham
Copy link
Copy Markdown
Member

Why are the tests failing?

🤷

@jorenham
Copy link
Copy Markdown
Member

Why are the tests failing?

I don't think this PR has anything to do with it, so I wouldn't worry about it.

@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Should I make another PR, deleting this? I removed the first two commits. Can that be the reason?

@jorenham
Copy link
Copy Markdown
Member

jorenham commented Jan 22, 2026

Should I make another PR, deleting this? I removed the first two commits. Can that be the reason?

No need; that's unrelated. We're seeing the same CI failures at other PRs

@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Should I make another PR, deleting this? I removed the first two commits. Can that be the reason?

No need; that's unrelated. We're seeing the same CI failures at other PRs

Okay, Thanks.
👍

@mattip
Copy link
Copy Markdown
Member

mattip commented Jan 23, 2026

The failure is due to a choco install failure

Failed to fetch results from V2 feed at 'https://community.chocolatey.org/api/v2/Packages(Id='pkgconfiglite',Version='0.28.0')' with following message : Response status code does not indicate success: 504 (Gateway Time-out).
Need to add specific handling for exception type NuGetResolverInputException
Unable to find package 'pkgconfiglite'. Existing packages must be restored before performing an install or update.

#25861 added --stoponfirstfailure to the choco command, but missed the wheel builds. Maybe restarting the failing CI runs will help

@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Any other changes required?

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>
@antareepsarkar
Copy link
Copy Markdown
Contributor Author

Any other changes required? Please tell.

@jorenham jorenham merged commit b40506c into numpy:main Jan 24, 2026
75 checks passed
@jorenham
Copy link
Copy Markdown
Member

Thanks @antareepsarkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

00 - Bug 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: meshgrid return type depends on the value of copy

3 participants