TST: fix limited API example in tests for latest Cython#30698
Merged
charris merged 1 commit intonumpy:mainfrom Jan 21, 2026
Merged
TST: fix limited API example in tests for latest Cython#30698charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
Cython 3.3 will require a minimum target of 3.9 for the limited API.
There is no reason for us to still test 3.6/3.7
Remove `#define Py_LIMITED_API` from a C source file, that's not a good
habit and it requires manually keeping the version in sync between
the C file and the meson.build file.
Also fix warnings like these:
```
WARNING: Project specifies no minimum version but uses features which were added in versions:
* 1.3.0: {'limited_api arg in python.extension_module'}
```
by requiring a recent Meson version.
charris
approved these changes
Jan 21, 2026
Member
|
Thanks Ralf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython 3.3 will require a minimum target of 3.9 for the limited API. There is no reason for us to still test 3.6/3.7
Remove
#define Py_LIMITED_APIfrom a C source file, that's not a good habit and it requires manually keeping the version in sync between the C file and the meson.build file.Also fix warnings like these:
by requiring a recent Meson version.