Skip to content

DEP: Deprecate numpy.fix in favor of numpy.trunc #30644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorenham merged 8 commits into from
Jan 13, 2026
Merged

DEP: Deprecate numpy.fix in favor of numpy.trunc #30644

jorenham merged 8 commits into from
Jan 13, 2026
+50 −5

Conversation

@skyvanguard
Copy link

@skyvanguard skyvanguard commented Jan 12, 2026

Summary

Deprecate numpy.fix as it provides identical functionality to numpy.trunc but is slower and is not part of the Array API standard.

Motivation

As noted in #30096:

  • numpy.fix and numpy.trunc produce identical results
  • numpy.trunc is ~2.5x faster than numpy.fix
  • The Array API standard defines trunc but not fix
  • The name trunc is clearer and more standard

Changes

  • Add DeprecationWarning to numpy.fix()
  • Update docstring with .. deprecated:: directive
  • Add tests to verify deprecation warning is emitted
  • Update existing tests to suppress deprecation warnings during functional tests
  • Add release note about deprecation

Performance comparison

In [1]: arr = np.random.random(1_000_000)*1000

In [2]: %timeit np.trunc(arr)
426 μs ± 15.1 μs per loop

In [3]: %timeit np.fix(arr)
1.06 ms ± 3.34 μs per loop

In [4]: np.all(np.trunc(arr) == np.fix(arr))
Out[4]: np.True_

Closes #30096

DEP: Deprecate numpy.fix in favor of numpy.trunc
4420e94 
Deprecate `numpy.fix` as it provides identical functionality to
`numpy.trunc` but is slower and is not part of the Array API standard.

- Add DeprecationWarning to numpy.fix()
- Update docstring with .. deprecated:: directive
- Add tests to verify deprecation warning is emitted
- Update existing tests to suppress deprecation warnings
- Add release note about deprecation

Closes numpy#30096
@jorenham

This comment was marked as resolved.

Sign in to view
jorenham
jorenham reviewed Jan 12, 2026
View reviewed changes
jorenham
jorenham reviewed Jan 12, 2026
View reviewed changes
jorenham
jorenham requested changes Jan 12, 2026
View reviewed changes
@skyvanguard
Copy link
Author

skyvanguard commented Jan 12, 2026

Done! Removed category=PendingDeprecationWarning from the stubs and updated the deprecation message to match the runtime warning.

@skyvanguard
Copy link
Author

skyvanguard commented Jan 12, 2026

Fixed! Updated to NumPy 2.5 and 2026. Thanks for catching that 😅

@skyvanguard
Copy link
Author

skyvanguard commented Jan 12, 2026

Updated tests to use @pytest.mark.filterwarnings instead of warnings.catch_warnings(). Thanks for the guidance!

jorenham
jorenham reviewed Jan 13, 2026
View reviewed changes
Use @pytest.mark.filterwarnings for fix deprecation in typing tests
8ecf22f 
Move the deprecation warning filter from the test data file to the
actual test function. This ensures the filter follows NumPy testing
conventions and doesn't use warnings.filterwarnings in a non-test file.
@jorenham jorenham added this to the 2.5.0 Release milestone Jan 13, 2026
@jorenham jorenham merged commit 60057c0 into numpy:main Jan 13, 2026
77 checks passed
@jorenham
Copy link
Member

jorenham commented Jan 13, 2026

Thanks @skyvanguard

@neutrinoceros neutrinoceros mentioned this pull request Jan 15, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

07 - Deprecation

Projects

None yet

Milestone

2.5.0 Release

Development

Successfully merging this pull request may close these issues.

DEP: Deprecate np.fix

2 participants

@skyvanguard @jorenham