TYP: histogram*: shape-typing and dtype specialization
#30545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The histogram function stubs were mostly incomplete, giving little type-safety. This adds (many) overloads for
histogram_bin_edges,histogram, andhistogramddfor specific input combinations to return specialized dtypes. This additionally changes the returned array types to include their (often 1d) shape-types.Don't let the many overloads scare you; because just like with death metal, once you can get past the machine-gun blastbeats and gutteral pig-squealing, then you'll find that there are actually a couple of notes hidden in there. So static typing is basically the death metal of Python (in a good way). I guess that must be why I like it then 🤔.