Skip to content

TYP: Fix return type of histogram2d #30526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorenham merged 1 commit into from
Dec 27, 2025
Merged

TYP: Fix return type of histogram2d #30526

jorenham merged 1 commit into from
Dec 27, 2025
+13 −13

Conversation

@BillTompkins
Copy link
Contributor

@BillTompkins BillTompkins commented Dec 27, 2025

Closes #30525

Testing

  • spin mypy passes with the updated tests
  • spin test -v passes
  • python tools/linter.py passes

Running the test in #30525 now results in the proper type information for the first histogram2d return value and the .tolist() of that np.array:

tests/minimal_numpy.py:10:17 - information: Type of "a" is "ndarray[tuple[Literal[2], Literal[2]], dtype[float64]]"
tests/minimal_numpy.py:11:17 - information: Type of "a[0]" is "Any"
tests/minimal_numpy.py:19:17 - information: Type of "al" is "list[list[float]]"
tests/minimal_numpy.py:20:17 - information: Type of "al[0]" is "list[float]"

jorenham
jorenham approved these changes Dec 27, 2025
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this looks correct.

@jorenham jorenham merged commit 4b3b270 into numpy:main Dec 27, 2025
14 checks passed
@jorenham jorenham mentioned this pull request Dec 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

41 - Static typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TYP: Incorrect type hint from histogram2d

2 participants

@BillTompkins @jorenham