BUG: Fix building on s390x with clang#28393
Merged
charris merged 1 commit intonumpy:mainfrom Mar 1, 2025
Merged
Conversation
clang on s390x did not have implementations of vector logical operators such as vec_and, vec_or and vec_xor in vecintrin.h until __VEC__ == 10305 which caused compile errors. Add implementations to allow the build to complete. Currently, clang >= 19 is required for all tests to pass because that is the minimum version supported by highway on s390x with clang.
Contributor
Author
|
From looking at other PR checks I'm guessing that some qemu builds randomly fail? I ran a ppc64le qemu build locally and it failed the same way a few times but eventually I got a build to complete and all tests passed. |
Member
There's a new failure that popped up in the last few days: #28405 Sorry for the confusion. The NumPy CI is sufficiently complicated it's rare we go more than a couple of weeks between random breakages. |
Member
|
Thanks @jonathan-albrecht-ibm . Let's give it a shot. |
Contributor
Author
|
Thanks for reviewing and merging @charris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang on s390x did not have implementations of vector logical operators such as vec_and, vec_or and vec_xor in vecintrin.h until VEC == 10305 and this caused compile errors. Add implementations to allow the build to complete.
Currently, clang >= 19 is required for all tests to pass because that is the minimum version supported by highway on s390x with clang.