MAINT: Use VQSORT_COMPILER_COMPATIBLE to determine if we should use VQSort#28202
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Jan 21, 2025
Merged
MAINT: Use VQSORT_COMPILER_COMPATIBLE to determine if we should use VQSort#28202ngoldbaum merged 1 commit intonumpy:mainfrom
ngoldbaum merged 1 commit intonumpy:mainfrom
Conversation
Previously we copied the compiler detection across from the Highway header, now we don't have to manually keep it up to date.
Member
|
I can build NumPy with both TSAN and ASAN on this branch, so I think this should be working as intended. Thanks so much for getting this fixed upstream and then updated here. |
Member
|
I am going to backport this for the highway update, see #28030. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we copied the compiler detection across from the Highway header, now we don't have to manually keep it up to date.