DEP: testing: disable deprecated use of keywords x/y#27738
Merged
charris merged 1 commit intonumpy:mainfrom Nov 28, 2024
Merged
DEP: testing: disable deprecated use of keywords x/y#27738charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
Member
|
Not that I think this is a big enough deprecation to worry, so happy if someone reviews+merges. But on principle we should probably consider 2.0 and 2.1 a single release for deprecation purposes, in order to stay with the ~1 year of deprecation. |
Contributor
Author
|
Oops, yeah. I forgot that 2.0 didn't come out until June. I'm happy to wait until 2.3; I had just set a reminder for one year because i didn't want to forget. |
Member
|
Thanks @mdhaber . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-24978 deprecated the use of keywords
xandyinnumpy.testing.assert_array_equalandnumpy.testing.assert_array_almost_equal.This PR removes the decorator that warned about the deprecation and allowed continued use of
xandy; after the PR, onlyactualanddesiredare accepted.