MAINT: Check for SVE support on demand#27472
Merged
mattip merged 1 commit intonumpy:mainfrom Sep 30, 2024
joaoe:defered_evaluation_sve
Merged
MAINT: Check for SVE support on demand#27472mattip merged 1 commit intonumpy:mainfrom joaoe:defered_evaluation_sve
mattip merged 1 commit intonumpy:mainfrom
joaoe:defered_evaluation_sve
Conversation
This was referenced Sep 29, 2024
Closed
The check would invoke an external process which would slow down imports
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TST: Make check for SVE support happen on demand and not during module import
The check would invoke an external process which would slow down imports
The external process is triggered during start-imports by sklearn (whoops). See #23954 This is the leftover bit from that bug report.