Skip to content

Conversation

@musvaage
Copy link
Contributor

@musvaage musvaage commented Sep 4, 2024

Closes #27336

@rkern
Copy link
Member

rkern commented Sep 4, 2024

I've commented on the ones that should be left alone. The others seem to be correct fixes, spelling-wise, though I haven't verified if any have practical considerations (e.g. if changing a warning message might have consequences for things that try to catch that warning message, etc.), but I doubt there are many of those.

@rkern
Copy link
Member

rkern commented Sep 4, 2024

Please don't force-push for PRs like this. It makes it very difficult to keep track of which changes have been reviewed and which still need review.

@musvaage
Copy link
Contributor Author

musvaage commented Sep 4, 2024

numpy/_core/tests/test_casting_unittests.py

presuming modifying this file is inconsequential

personally my inclination is to merge this commit which implements solely those fixes from the ticket's shell script

the ticket's ed output could later be revisited and a second pull made

@musvaage musvaage marked this pull request as ready for review September 4, 2024 17:02
@charris charris changed the title fix typos MAINT: fix typos Sep 4, 2024
@rkern
Copy link
Member

rkern commented Sep 6, 2024

The lint checks need to be fixed before merging.

@mattip
Copy link
Member

mattip commented Sep 8, 2024

Since the linting errors are in the deprecated distutils module, I don't think they should be fixed.

Copy link
Member

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through these and they all seem reasonable, including the warning/error message fixes.

@charris charris merged commit d6bfeb0 into numpy:main Sep 11, 2024
@charris
Copy link
Member

charris commented Sep 11, 2024

Thanks @musvaage .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

typos

4 participants