-
-
Notifications
You must be signed in to change notification settings - Fork 12k
MAINT: fix typos #27344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: fix typos #27344
Conversation
|
I've commented on the ones that should be left alone. The others seem to be correct fixes, spelling-wise, though I haven't verified if any have practical considerations (e.g. if changing a warning message might have consequences for things that try to catch that warning message, etc.), but I doubt there are many of those. |
|
Please don't force-push for PRs like this. It makes it very difficult to keep track of which changes have been reviewed and which still need review. |
|
numpy/_core/tests/test_casting_unittests.py presuming modifying this file is inconsequential personally my inclination is to merge this commit which implements solely those fixes from the ticket's shell script the ticket's |
|
The lint checks need to be fixed before merging. |
|
Since the linting errors are in the deprecated distutils module, I don't think they should be fixed. |
mattip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through these and they all seem reasonable, including the warning/error message fixes.
|
Thanks @musvaage . |
Closes #27336