BUG: Fix PyArray_ZeroContiguousBuffer (resize) with struct dtypes#27226
Merged
mattip merged 1 commit intonumpy:mainfrom Aug 16, 2024
Merged
BUG: Fix PyArray_ZeroContiguousBuffer (resize) with struct dtypes#27226mattip merged 1 commit intonumpy:mainfrom
PyArray_ZeroContiguousBuffer (resize) with struct dtypes#27226mattip merged 1 commit intonumpy:mainfrom
Conversation
We allow the structured dtype to return NULL for the zero fill function to indicate that a simple memset is sufficient. Also simplifies error handling a bit. The get_fill_zero_loop function must clean up on error and not return references if returns a `NULL` loop.
Member
|
Thanks @seberg |
Member
|
Thanks for the quick fix and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow the structured dtype to return NULL for the zero fill function to indicate that a simple memset is sufficient.
Also simplifies error handling a bit. The get_fill_zero_loop function must clean up on error and not return references if returns a
NULLloop.Closes gh-27225
EDIT: Sorry, forgot about the times. This needs to be backported to 2.1.