BUG: Fix NPY_RAVEL_AXIS on backwards compatible NumPy 2 builds#27202
Merged
charris merged 1 commit intonumpy:mainfrom Aug 13, 2024
Merged
BUG: Fix NPY_RAVEL_AXIS on backwards compatible NumPy 2 builds#27202charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
The value was simply hardcoded to the wrong thing in the dynamic path...
Member
|
Worth having a release note as a bugfix? |
Member
Author
|
Dunno, it simply didn't work before. I would hope nobody really will build with 2.0.1 after 2.0.2 is released. |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value was simply hardcoded to the wrong thing in the dynamic path...
Closes gh-27194
Unfortunately, I think we should backport this to both 2.1 and 2.0.2, since the current value was just wrong.