Skip to content

TYP: Fix incompatible overrides in the numpy._typing._ufunc stubs#27153

Merged
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/ufunc-incompatible-overrides
Aug 14, 2024
Merged

TYP: Fix incompatible overrides in the numpy._typing._ufunc stubs#27153
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/ufunc-incompatible-overrides

Conversation

@jorenham
Copy link
Copy Markdown
Member

@jorenham jorenham commented Aug 9, 2024

This was introduced in #26871, which changed some numpy.ufunc properties from str to LiteralString.

Copy link
Copy Markdown
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jorenham. Too bad the tests didn't catch this. I'll mark it for backporting to 2.1.x since the PR that introduced this will be in 2.1.0

@rgommers rgommers merged commit 99d319e into numpy:main Aug 14, 2024
@rgommers rgommers added the 09 - Backport-Candidate PRs tagged should be backported label Aug 14, 2024
@rgommers rgommers added this to the 2.2.0 release milestone Aug 14, 2024
@jorenham jorenham deleted the typing/ufunc-incompatible-overrides branch August 14, 2024 17:37
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants