Skip to content

TYP: Simplified ufunc imports in numpy._typing#27152

Merged
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/ufunc-stubs-vs-runtime
Aug 14, 2024
Merged

TYP: Simplified ufunc imports in numpy._typing#27152
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/ufunc-stubs-vs-runtime

Conversation

@jorenham
Copy link
Copy Markdown
Member

@jorenham jorenham commented Aug 9, 2024

This adds the runtime counterpart for the numpy._typing._ufunc stubs, so that the related runtime/type-checking import logic within numpy._typing isn't needed anymore.

Copy link
Copy Markdown
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jorenham

@rgommers rgommers merged commit b664fe0 into numpy:main Aug 14, 2024
@rgommers rgommers added this to the 2.2.0 release milestone Aug 14, 2024
@jorenham jorenham deleted the typing/ufunc-stubs-vs-runtime branch August 14, 2024 17:48
@jorenham jorenham changed the title TYP: Simpllified ufunc imports in numpy._typing TYP: Simplified ufunc imports in numpy._typing Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants