TYP: Sane defaults for the platform-specific NBitBase types.#27150
Merged
rgommers merged 1 commit intonumpy:mainfrom Aug 14, 2024
Merged
TYP: Sane defaults for the platform-specific NBitBase types.#27150rgommers merged 1 commit intonumpy:mainfrom
NBitBase types.#27150rgommers merged 1 commit intonumpy:mainfrom
Conversation
NBItBase types.NBitBase types.
839baa9 to
bef0fb3
Compare
Member
|
This looks good, but it accumulated a merge conflict - could you please update @jorenham? |
This will help for those that don't use the mypy plugin.
bef0fb3 to
c109fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help for those that don't use the mypy plugin.
The defaults match the
numpy.dtypesstubs.The new
._typing._nbit_basemodule was needed to avoid a circular input.