BUG: Do not accidentally store dtype metadata in np.save#27143
Merged
charris merged 1 commit intonumpy:mainfrom Aug 8, 2024
Merged
BUG: Do not accidentally store dtype metadata in np.save#27143charris merged 1 commit intonumpy:mainfrom
np.save#27143charris merged 1 commit intonumpy:mainfrom
Conversation
We had logic in place to drop (most) metadata, but the change had a small bug: During saving, we were still using the one with metadata... Maybe doesn't quite close it, but big enough of an improvement for now, I think, so Closes numpygh-14142
Member
|
Is a backport also needed to 2.0? |
Member
Author
|
This has been around for a long time, so don't care, but maybe Tom does. Since the metadata dropping worked and I think loading never really did, I think it is save to backport to 2.0, though/ |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had logic in place to drop (most) metadata, but the change had a small bug: During saving, we were still using the one with metadata...
Maybe doesn't quite close it, but big enough of an improvement for now, I think, so
Closes gh-14142