BUG: Ensure that scalar binops prioritize __array_ufunc__#27117
Merged
charris merged 2 commits intonumpy:mainfrom Aug 7, 2024
Merged
BUG: Ensure that scalar binops prioritize __array_ufunc__#27117charris merged 2 commits intonumpy:mainfrom
charris merged 2 commits intonumpy:mainfrom
Conversation
If array-ufunc is implemented, we must call always use it for all operators (that seems to be the promise). If __array_function__ is defined we are in the clear w.r.t. recursion because the object is either an array (can be unpacked, but already checked earlier now also), or it cannot call the ufunc without unpacking itself (otherwise it would cause recursion). There is an oddity about `__array_wrap__`. Rather than trying to do odd things to deal with it, I added a comment explaining why it doens't matter (roughly: don't use our scalar priority if you want to be sure to get a chance).
Member
|
FWIW this PR fixes some (all?) of the |
mroeschke
reviewed
Aug 6, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
charris
approved these changes
Aug 7, 2024
Member
|
Thanks Sebastian. |
Member
|
Can we please trigger a nightlies rebuild so that pandas CI gets happier again? |
Member
Author
done, should take 30 minutes at most. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If array-ufunc is implemented, we must call always use it for all operators (that seems to be the promise).
If array_function is defined we are in the clear w.r.t. recursion because the object is either an array (can be unpacked, but already checked earlier now also), or it cannot call the ufunc without unpacking itself (otherwise it would cause recursion).
There is an oddity about
__array_wrap__. Rather than trying to do odd things to deal with it, I added a comment explaining why it doens't matter (roughly: don't use our scalar priority if you want to be sure to get a chance).