Skip to content

TYP: Fixed & improved type hints for numpy.histogram2d#27100

Merged
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/27092-histogram2d-bins-float
Aug 14, 2024
Merged

TYP: Fixed & improved type hints for numpy.histogram2d#27100
rgommers merged 1 commit intonumpy:mainfrom
jorenham:typing/27092-histogram2d-bins-float

Conversation

@jorenham
Copy link
Copy Markdown
Member

@jorenham jorenham commented Aug 3, 2024

This fixes #27092, as well as the overlapping overloads with incompatible return types (see #27032) in numpy.histogram2d.

@jorenham jorenham force-pushed the typing/27092-histogram2d-bins-float branch from 38fc2dc to 636c275 Compare August 12, 2024 16:49
Copy link
Copy Markdown
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorenham! This LGTM, and since it fixes a reported bug I'll mark it for backporting.

@rgommers rgommers merged commit 51fa653 into numpy:main Aug 14, 2024
@rgommers rgommers added this to the 2.2.0 release milestone Aug 14, 2024
@rgommers rgommers added the 09 - Backport-Candidate PRs tagged should be backported label Aug 14, 2024
@jorenham jorenham deleted the typing/27092-histogram2d-bins-float branch August 14, 2024 19:21
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TYP: histogram2d doesn't like bins arrays with floats

3 participants