BUG: add missing error handling in public_dtype_api.c#27098
Merged
Conversation
mhvk
approved these changes
Aug 3, 2024
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Makes sense. Would also be good to update the comment for the actual routine, since currently it claims to do no error checking, which is perhaps what led to this mistake:
numpy/numpy/_core/src/multiarray/dtypemeta.c
Lines 159 to 172 in 0469e1d
Member
|
Thanks @ngoldbaum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SwayamInSync ran into some confusing behaviors working on a DType and I tracked it down to missing error handling here
Hard to write a test for this without defining an invalid DType.