TYP: Annotate numpy._core._type_aliases.#26944
Merged
rgommers merged 1 commit intonumpy:mainfrom Aug 14, 2024
Merged
Conversation
37dab0d to
08e286e
Compare
08e286e to
3704d97
Compare
rgommers
approved these changes
Aug 14, 2024
Member
rgommers
left a comment
There was a problem hiding this comment.
Thanks Joren, LGTM!
This sat here for a little too long; tests still pass locally after rebasing on main though, so good to go as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost all annotations in
numpy._core._type_aliaseswere missing.The only previously existing annotation was for
.sctypeDict, which this PR modified to be aFinal, and to have a key type ofstr(instead ofint | str).And because it is exported as
numpy.sctypeDict, and therefore part of the public API, a (simple) type-test has been added for it.