Skip to content

BUG: int32 and intc should both appear in sctypes#26441

Merged
charris merged 1 commit intonumpy:mainfrom
mattip:issue26439
May 15, 2024
Merged

BUG: int32 and intc should both appear in sctypes#26441
charris merged 1 commit intonumpy:mainfrom
mattip:issue26439

Conversation

@mattip
Copy link
Copy Markdown
Member

@mattip mattip commented May 15, 2024

Fix issue #26439 where in 32-bit builds np.int32 did not appear in sctypes, so np.isdtype(np.int32, 'integral') was False.

The issue was that

[t.type for t in set(typeinfo.values())]

is not the same as

set([t.type for t in typeinfo.values()])

The latter has more members, and is the one used now.

@mattip mattip linked an issue May 15, 2024 that may be closed by this pull request
@ngoldbaum ngoldbaum added the 09 - Backport-Candidate PRs tagged should be backported label May 15, 2024
@ngoldbaum
Copy link
Copy Markdown
Member

CI failures look unrelated (not sure why installing g++-13 decided to suddenly stop working on Ubuntu 22.04).

This looks correct to me and thanks for adding a test. Subtle issue...

@charris charris merged commit 19cedd8 into numpy:main May 15, 2024
@charris
Copy link
Copy Markdown
Member

charris commented May 15, 2024

Thanks Matti.

CI is becoming annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: on 32-bit linux build, int32 is missing from sctypes["int"]

3 participants