DOC: fix np.unique release notes [skip cirrus]#26369
Merged
seberg merged 1 commit intonumpy:mainfrom May 2, 2024
Merged
Conversation
Member
|
Thanks @andyfaff |
Member
|
This should have been made against the EDIT: the notes in the branch have already diverged from main. |
Member
|
Ouch, sorry, I was wondering about that after merging, but wasn't sure then :/. |
Member
|
Not to worry, I can fix it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect link in the numpy2.0 release notes to #25553.
Noticed when the changes introduced in that PR broke a downstream package. Caused a bit of head scratching.
Perhaps the
np.uniquedocstring could do with being amended with a 'changed in 2.0' note, even if the original behaviour was considered a bug. The docstring doesn't indicate that anything was different between 1.26.4 and 2.0, so when my code broke I thought it was a bug introduced into numpy2.