MAINT: Simplify bugfix for even rfft#26359
Merged
charris merged 1 commit intonumpy:mainfrom Apr 27, 2024
Merged
Conversation
WarrenWeckesser
approved these changes
Apr 27, 2024
Member
WarrenWeckesser
left a comment
There was a problem hiding this comment.
Thanks for fixing my fix!
Member
|
Thanks Marten. I'd need to look deeper into the code to be sure how this works, but otherwise it looks reasonable and the tests pass, so in it goes. |
Contributor
Author
It's all in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly improved fix for #26349, which changes the code to actually do what a comment stated it would, making the fix from #26354 no longer necessary. Of course, it keeps the tests, so that we can be sure the fix actually is correct.
Ideally, backported for 2.0.0 as well.