BUG: Fix invalid constructor in string_fastsearch.h with C++ >= 20.#26324
Merged
seberg merged 1 commit intonumpy:mainfrom Apr 22, 2024
Merged
BUG: Fix invalid constructor in string_fastsearch.h with C++ >= 20.#26324seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
This is an error with -std=gnu++20 at least with gcc 11 to 13, and will be an explicit warning with gcc >= 14. See https://godbolt.org/z/YdoTc7r8f In practice, it avoids these compilation errors: In file included from ../numpy/_core/src/umath/string_ufuncs.cpp:20: ../numpy/_core/src/umath/string_fastsearch.h:63:31: error: expected unqualified-id before ')' token 63 | CheckedIndexer<char_type>() | ^ ../numpy/_core/src/umath/string_fastsearch.h:69:40: error: expected ')' before '*' token 69 | CheckedIndexer<char_type>(char_type *buf, size_t len) | ~ ^~ |
Contributor
Author
|
Note: this problem impacts the upcoming release 2.0, so most likely you should backport it in the 2.0 branch as well ;) |
Member
|
LGTM, thanks @Romain-Geissler-1A. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an error with -std=gnu++20 at least with gcc 11 to 13, and will be an explicit warning with gcc >= 14. See
https://godbolt.org/z/YdoTc7r8f
In practice, it avoids these compilation errors: