BUG: use PyArray_SafeCast in array_astype#26317
Merged
charris merged 1 commit intonumpy:mainfrom Apr 20, 2024
Merged
Conversation
Member
|
Thanks Nathan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed today that passing a distinct
StringDTypeinstance toastypewasn't sufficient to actually change the dtype withcopy=False. This fixes that issue by usingPyArray_SafeCastinstead ofPyArray_EquivTypes.See #26147 which introduced
PyArray_SafeCastand fixed a similar issue.