DOC: Follow-up fixes for new theme#26311
Merged
mattip merged 1 commit intonumpy:mainfrom Apr 18, 2024
Merged
Conversation
Fixes spacing between logo and navbar section titles, and admonition colors. [skip azp] [skip cirrus]
Member
|
Thanks. If you add this to the commit, only doc building (circleci) will run: I wonder how we can make that the default for PRs that only touch |
Member
|
Looks better: compare this PR to the same page in devdocs. The heading fits into one line and the "Examples" admonitions are style in a blue rather than an orange. |
Member
|
Thanks @melissawm |
Member
Author
Don't know about a default, but I'd be happy to submit a PR for a [docs only] option like we have in scipy: https://github.com/scipy/scipy/blob/main/.github/workflows/commit_message.yml |
Member
|
A [docs only] option makes sense to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes spacing between logo and navbar section titles, and admonition colors.
This is a follow-up to #26125 - I noticed the navbar spacing was off, and that the regular admonitions were erroneously taking colors from the legacy admonition colors.