DOC: add explanation of dtype to parameter values for np.append#26303
DOC: add explanation of dtype to parameter values for np.append#26303mattip merged 6 commits intonumpy:mainfrom
Conversation
|
|
2a7c235 to
1807e08
Compare
|
all right. tests have passed now. |
numpy/lib/_function_base_impl.py
Outdated
| flattened before use. If dtype of values is different from the | ||
| dtype of arr then their dtypes are compared to figure out the |
There was a problem hiding this comment.
| flattened before use. If dtype of values is different from the | |
| dtype of arr then their dtypes are compared to figure out the | |
| flattened before use. If dtype of `values` is different from the | |
| dtype of `arr` then their dtypes are compared to figure out the |
|
Please add |
…rus][skip actions]
Thank you for pointing. Done. |
|
@mattip Please let me know if any more changes need to be done. |
|
I think this does not actually address the issue that prompted the PR, which was that calling |
…[skip azp][skip cirrus][skip actions]
mattip
left a comment
There was a problem hiding this comment.
A few comments, what do you think?
numpy/lib/_function_base_impl.py
Outdated
| >>> c.dtype | ||
| float64 | ||
|
|
||
| Default dtype for empty lists is `float64` thus making the output of dtype |
There was a problem hiding this comment.
Move this comment to above the example
| Default dtype for empty lists is `float64` thus making the output of dtype | |
| Default dtype for empty ndarrays is `float64` thus making the output of dtype |
|
Thanks @tuhinsharma121 |
Improve doc strings to include explanation of
dtypeto parametervaluesfornp.appendcloses #26291